deps: fix V8 compilation on Apple clang 13 & 14 #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 12.9. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
dllexport introduces issues when compiling with MSVC. PR-URL: nodejs/node#47251 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
It introduces process hangs on some platforms because Node.js doesn't tear down V8 correctly. Disable it while we work on a solution. Refs: nodejs/node#47297 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902 PR-URL: nodejs/node#47450 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14221 PR-URL: nodejs/node#49639 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
After enabling -std:c++20 on Windows, patch is now much smaller. PR-URL: nodejs/node#52465 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5447267 Co-authored-by: Michaël Zasso <targos@protonmail.com>
As V8 has moved away from wrapper-descriptor-based CppHeap, this patch: 1. Create the CppHeap without using wrapper descirptors. 2. Deprecates node::SetCppgcReference() in favor of v8::Object::Wrap() since the wrapper descriptor is no longer relevant. It is still kept as a compatibility layer for addons that need to also work on Node.js versions without v8::Object::Wrap().
Add/remove abseil files introduced by V8 12.7 update found by: ``` git diff-tree --no-commit-id --name-status 0ec8f7eea3 -r | grep '^[AD].*abseil.*' ```
Two fields on the `v8::FastApiCallbackOptions` struct were deprecated recently: `fallback` and `wasm_memory`. This PR removes uses of these two fields in node.js.
|
The third commit fixes the osx11 failure in nodejs/node#54077 . Second commit is only present in canary for now. Not sure about the first one, looks recent. |
|
cc @targos |
|
Nice! I suggest you upstream 40548f8. It makes sense to include vector if vector is used in the file. |
|
Current LLVM on Apple platforms is version 15, released in 2023. Version 16 is in its 5th beta and should enter soon RC1. |
|
Uploaded the third commit to https://chromium-review.googlesource.com/c/v8/v8/+/5771451 and the first to https://chromium-review.googlesource.com/c/v8/v8/+/5771471 (not 100% sure about the second commit yet, it fixes the bug but maybe I should simplify it..) |
|
Found another issue in Xcode 13: nodejs/node#54077 (comment) |
|
It turns out we also need c21cbdf for Xcode 13: https://ci.nodejs.org/job/node-test-commit-osx/60282/nodes=osx11-x64/console |
nodejs-github-bot
force-pushed
the
canary
branch
3 times, most recently
from
2a6f55f to
c4c3e7c
Compare
nodejs-github-bot
force-pushed
the
canary
branch
8 times, most recently
from
94dd182 to
62cb155
Compare
nodejs-github-bot
force-pushed
the
canary
branch
7 times, most recently
from
6428a27 to
0ec56a4
Compare
nodejs-github-bot
force-pushed
the
canary
branch
7 times, most recently
from
d3bd189 to
6da2fe9
Compare
nodejs-github-bot
force-pushed
the
canary
branch
6 times, most recently
from
16bb2f9 to
ca0026d
Compare
nodejs-github-bot
force-pushed
the
canary
branch
2 times, most recently
from
726adce to
11be423
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.