Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial unix socket support to Garnet. The unix domain socket path can be specified with
--unixsocket
switch. Becausestring address, int port
pair was used everywhere, this change required a lot of tiny changes in testing and networking logic. There is more clean-up work left in some parts of the code, e.g. usingIPEndPoint
to represent cluster nodes instead of the(string address, int port)
tuple.I'm leaving implementation of
--unixsocketperm
switch to be done as a follow-up. I'm also for now making the server initialization throwNotImplementedException
if user attempts to specify unix socket listener in cluster mode. Supporting cluster mode would need bit more work to have two different types of listener endpoints active.TODO:
Contributes to #682