Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: Add Unix socket support #944

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

PaulusParssinen
Copy link
Contributor

@PaulusParssinen PaulusParssinen commented Jan 22, 2025

This PR adds initial unix socket support to Garnet. The unix domain socket path can be specified with --unixsocket switch. Because string address, int port pair was used everywhere, this change required a lot of tiny changes in testing and networking logic. There is more clean-up work left in some parts of the code, e.g. using IPEndPoint to represent cluster nodes instead of the (string address, int port) tuple.

I'm leaving implementation of --unixsocketperm switch to be done as a follow-up. I'm also for now making the server initialization throw NotImplementedException if user attempts to specify unix socket listener in cluster mode. Supporting cluster mode would need bit more work to have two different types of listener endpoints active.

TODO:

  • Add some tests before marking PR ready
  • more testing

Contributes to #682

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant