Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch lua to fix CVE-2020-24371 [Medium] #12034

Open
wants to merge 1 commit into
base: fasttrack/3.0
Choose a base branch
from

Conversation

kevin-b-lockwood
Copy link
Contributor

@kevin-b-lockwood kevin-b-lockwood commented Jan 22, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Fix CVE-2020-24371

Change Log
  • Apply patch for CVE-2020-24371
  • remove an obsolete patch from the spec as housekeeping.
Does this affect the toolchain?

YES

Links to CVEs
Test Methodology
  • Pipeline build id: Local build

@kevin-b-lockwood kevin-b-lockwood requested a review from a team as a code owner January 22, 2025 23:59
@kevin-b-lockwood kevin-b-lockwood force-pushed the kevin-b-lockwood/lua-CVE-2020-24371 branch 2 times, most recently from b7aece2 to 06272c4 Compare January 23, 2025 00:08
This also involved removing a no-longer used patch from the spec as
housekeeping.
@kevin-b-lockwood kevin-b-lockwood force-pushed the kevin-b-lockwood/lua-CVE-2020-24371 branch from 06272c4 to 103a00a Compare January 23, 2025 00:10
@kevin-b-lockwood
Copy link
Contributor Author

That took a couple tries! First time dealing with a package that affects the toolchain.

@kevin-b-lockwood kevin-b-lockwood changed the title Patch lua to fix CVE-2020-24371 Patch lua to fix CVE-2020-24371 [Medium] Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant