Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change kernel-mft rpm name to mft_kernel #12025

Open
wants to merge 3 commits into
base: 3.0-dev
Choose a base branch
from

Conversation

binujp
Copy link
Contributor

@binujp binujp commented Jan 22, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

To comply AZL spec standard mandates renaming kernel-mft*.rpm to mft_kernel rpm and add a provides to satisfy dependencies to the old name.

Change Log
  • Change
  • Change
  • Change
Does this affect the toolchain?

YES/NO
NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Pipeline build id: xxxx

@binujp binujp requested a review from a team as a code owner January 22, 2025 16:33
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels Jan 22, 2025
# Best practice for specs mandate package name and rpm name must
# match. Default mft_kernel spec set rpm name as kernel-mft. To
# comply, we set Name as mft_kernel but add a Provides for kernel-mft.
Provides: kernel-mft
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please always add version information for Provides, so that each new version provides its own. Otherwise, if you try to install a specific version of kernel-mft, the package manager may not be able to find it.

Suggested change
Provides: kernel-mft
Provides: kernel-mft = %{version}-%{release}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, will add that.

Comment on lines 56 to 58
# Best practice for specs mandate package name and rpm name must
# match. Default mft_kernel spec set rpm name as kernel-mft. To
# comply, we set Name as mft_kernel but add a Provides for kernel-mft.
Copy link
Contributor

@PawelWMS PawelWMS Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is not entirely correct. It's a match between the spec file name and the Name tag is what we're trying to follow. To give more context, the Name tag defines the name of the default subpackage but not all specs produce their default subpackages.

If you wish to keep a comment for future reference, this should be a bit more accurate:

Suggested change
# Best practice for specs mandate package name and rpm name must
# match. Default mft_kernel spec set rpm name as kernel-mft. To
# comply, we set Name as mft_kernel but add a Provides for kernel-mft.
# Azure Linux attempts to match the spec file name and the "Name" tag.
# Upstream's mft_kernel spec set rpm name as kernel-mft. To
# comply, we set "Name" as mft_kernel but add a "Provides" for kernel-mft.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw. you're also free to ignore the default package completely and just create one that's called kernel-mft, if that's preferable over a Provides.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw. you're also free to ignore the default package completely and just create one that's called kernel-mft, if that's preferable over a Provides.

Sorry, I am not sure I understood this. Did you mean keep everything the same as earlier and add a provides mft_kernel to satisfy dependency graphing tools? I will take the rephrased comment verbatim or rephrase depending on what you meant here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants