-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change kernel-mft rpm name to mft_kernel #12025
base: 3.0-dev
Are you sure you want to change the base?
Conversation
# Best practice for specs mandate package name and rpm name must | ||
# match. Default mft_kernel spec set rpm name as kernel-mft. To | ||
# comply, we set Name as mft_kernel but add a Provides for kernel-mft. | ||
Provides: kernel-mft |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please always add version information for Provides
, so that each new version provides its own. Otherwise, if you try to install a specific version of kernel-mft
, the package manager may not be able to find it.
Provides: kernel-mft | |
Provides: kernel-mft = %{version}-%{release} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, will add that.
SPECS/mft_kernel/mft_kernel.spec
Outdated
# Best practice for specs mandate package name and rpm name must | ||
# match. Default mft_kernel spec set rpm name as kernel-mft. To | ||
# comply, we set Name as mft_kernel but add a Provides for kernel-mft. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment is not entirely correct. It's a match between the spec file name and the Name
tag is what we're trying to follow. To give more context, the Name
tag defines the name of the default subpackage but not all specs produce their default subpackages.
If you wish to keep a comment for future reference, this should be a bit more accurate:
# Best practice for specs mandate package name and rpm name must | |
# match. Default mft_kernel spec set rpm name as kernel-mft. To | |
# comply, we set Name as mft_kernel but add a Provides for kernel-mft. | |
# Azure Linux attempts to match the spec file name and the "Name" tag. | |
# Upstream's mft_kernel spec set rpm name as kernel-mft. To | |
# comply, we set "Name" as mft_kernel but add a "Provides" for kernel-mft. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw. you're also free to ignore the default package completely and just create one that's called kernel-mft
, if that's preferable over a Provides
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw. you're also free to ignore the default package completely and just create one that's called
kernel-mft
, if that's preferable over aProvides
.
Sorry, I am not sure I understood this. Did you mean keep everything the same as earlier and add a provides mft_kernel to satisfy dependency graphing tools? I will take the rephrased comment verbatim or rephrase depending on what you meant here.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-static
subpackages, etc.) have had theirRelease
tag incremented../cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./LICENSES-AND-NOTICES/SPECS/data/licenses.json
,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md
,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passSummary
What does the PR accomplish, why was it needed?
To comply AZL spec standard mandates renaming kernel-mft*.rpm to mft_kernel rpm and add a provides to satisfy dependencies to the old name.
Change Log
Does this affect the toolchain?
YES/NO
NO
Associated issues
Links to CVEs
Test Methodology