Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes internal or un-exported deprecated things #23629

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anthony-murphy
Copy link
Contributor

This change is just cleanup of deprecated things which are unused, internal, and/or unexported.

@Copilot Copilot bot review requested due to automatic review settings January 22, 2025 18:53
@anthony-murphy anthony-murphy requested a review from a team as a code owner January 22, 2025 18:53
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: sharedstring area: driver Driver related issues area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch labels Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 20 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • packages/drivers/odsp-driver/src/odspDocumentServiceFactoryWithCodeSplit.ts: Evaluated as low risk
  • packages/test/test-utils/src/DriverWrappers.ts: Evaluated as low risk
  • packages/dds/sequence/src/sequence.ts: Evaluated as low risk
  • packages/framework/attributor/src/mixinAttributor.ts: Evaluated as low risk
  • packages/dds/sequence/src/intervalCollectionMapInterfaces.ts: Evaluated as low risk
  • packages/common/driver-definitions/src/index.ts: Evaluated as low risk
  • packages/common/driver-definitions/src/protocol/consensus.ts: Evaluated as low risk
  • packages/test/test-utils/src/timeoutUtils.ts: Evaluated as low risk
  • packages/drivers/odsp-driver/src/index.ts: Evaluated as low risk
  • packages/runtime/container-runtime/src/gc/index.ts: Evaluated as low risk
  • packages/common/container-definitions/src/error.ts: Evaluated as low risk
  • packages/dds/sequence/src/index.ts: Evaluated as low risk
  • packages/test/test-utils/src/index.ts: Evaluated as low risk
  • packages/common/driver-definitions/src/protocol/tokens.ts: Evaluated as low risk
  • packages/loader/container-loader/src/protocol/quorum.ts: Evaluated as low risk
@anthony-murphy anthony-murphy force-pushed the remove-internal-deprecated branch from 5a39110 to 919f6d8 Compare January 22, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: sharedstring area: dds Issues related to distributed data structures area: driver Driver related issues area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants