-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHANGELOG: update backport info for #19179 #19260
Conversation
CHANGELOG/CHANGELOG-3.4.md
Outdated
@@ -8,6 +8,7 @@ Previous change logs can be found at [CHANGELOG-3.3](https://github.com/etcd-io/ | |||
|
|||
### etcd server | |||
- [Avoid deadlock in etcd.Close when stopping during bootstrapping](https://github.com/etcd-io/etcd/pull/19166) | |||
- [mvcc: restore tombstone index if it's first revision](https://github.com/etcd-io/etcd/pull/19251) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we describe the changelog as fixes to a problem, not as change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added Fix
prefix
515f8ff
to
cc2cb83
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 24 files with indirect coverage changes @@ Coverage Diff @@
## main #19260 +/- ##
==========================================
+ Coverage 68.83% 68.84% +0.01%
==========================================
Files 420 420
Lines 35670 35675 +5
==========================================
+ Hits 24552 24562 +10
+ Misses 9697 9683 -14
- Partials 1421 1430 +9 Continue to review full report in Codecov by Sentry.
|
CHANGELOG/CHANGELOG-3.4.md
Outdated
@@ -8,6 +8,7 @@ Previous change logs can be found at [CHANGELOG-3.3](https://github.com/etcd-io/ | |||
|
|||
### etcd server | |||
- [Avoid deadlock in etcd.Close when stopping during bootstrapping](https://github.com/etcd-io/etcd/pull/19166) | |||
- Fix [mvcc: restore tombstone index if it's first revision](https://github.com/etcd-io/etcd/pull/19251) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Fix [mvcc: restore tombstone index if it's first revision](https://github.com/etcd-io/etcd/pull/19251) | |
- Fix [missing delete event on watch opened on same revision as compaction request](https://github.com/etcd-io/etcd/pull/19251) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Updated
CHANGELOG/CHANGELOG-3.5.md
Outdated
@@ -8,6 +8,7 @@ Previous change logs can be found at [CHANGELOG-3.4](https://github.com/etcd-io/ | |||
### etcd server | |||
- Avoid deadlock in etcd.Close when stopping during bootstrapping, see https://github.com/etcd-io/etcd/pull/19167 and https://github.com/etcd-io/etcd/pull/19258. | |||
- [Print warning messages if any of the deprecated v2store related flags is set](https://github.com/etcd-io/etcd/pull/18999) | |||
- Fix [mvcc: restore tombstone index if it's first revision](https://github.com/etcd-io/etcd/pull/19249) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
Signed-off-by: Wei Fu <fuweid89@gmail.com>
cc2cb83
to
2bdbeb0
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.