Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PowerFxConfig.AdditionalFunctions #2821

Open
MikeStall opened this issue Jan 18, 2025 · 0 comments
Open

Remove PowerFxConfig.AdditionalFunctions #2821

MikeStall opened this issue Jan 18, 2025 · 0 comments

Comments

@MikeStall
Copy link
Contributor

Remove PowerFxConfig.AdditionalFunctions

internal readonly Dictionary<TexlFunction, IAsyncTexlFunction> AdditionalFunctions = new ();

This is a layering violation. It's a map in Config that maps TexlFunction to Interpreter implementations.
But Config lives in Fx.Core, so it can't point to interpreter implementations.

Having "EnableXXX" on config that adds function implementations forces a problem here.

One workaround we used elsewhere was like for Json - add a derived TexlFunction that implements the interpreter interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant