New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply return result type check to all function implementations. #2820

Open

MikeStall opened this issue Jan 18, 2025 · 0 comments

Contributor

MikeStall commented Jan 18, 2025

Functions implemented via AsyncFunctionPtr have an additional type check on the return result.
This chekc ought to be apply to all implementations.

Power-Fx/src/libraries/Microsoft.PowerFx.Interpreter/EvalVisitor.cs

Line 398 in 0fa1968

    
           if (!(result.IRContext.ResultType._type == node.IRContext.ResultType._type || result is ErrorValue || result.IRContext.ResultType is BlankType))

It fails on some, including these:

AsTypeIsTypeParseJSONTests.cs ,
BlobTests.cs line
ValidateNoRecordToRecordAggregateCoercionCurrencyth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment